Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(io): Avoid spreading long arrays #1573

Merged
merged 2 commits into from
Nov 29, 2024
Merged

fix(io): Avoid spreading long arrays #1573

merged 2 commits into from
Nov 29, 2024

Conversation

donmccurdy
Copy link
Owner

@donmccurdy donmccurdy commented Nov 29, 2024 •
edited
Loading

For large arrays, patterns like results.push(...array) may lead to Maximum call stack size exceeded errors. In the example fixed here, I/O concatenates some 1M+ accessors from 1800+ animations.

@donmccurdy donmccurdy added bug Something isn't working package:core performance labels Nov 29, 2024
@donmccurdy donmccurdy added this to the v4.1 milestone Nov 29, 2024
@donmccurdy donmccurdy mentioned this pull request Nov 29, 2024
Closed
@donmccurdy donmccurdy merged commit 0d6025e into main Nov 29, 2024
7 checks passed
@donmccurdy donmccurdy deleted the fix/writer-no-spread-push branch November 29, 2024 12:53
@donmccurdy donmccurdy mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working package:core performance
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.

Resampling fails with Maximum call stack size exceeded
1 participant
@donmccurdy